fix(pve): serve PVE requests under /api/pve and drop per-gateway rewrites by xuang7 · Pull Request #6130 · apache/texera

xuang7 · 2026-07-05T02:39:54Z

What changes were proposed in this PR?

The single-node NGINX gateway (bin/single-node/nginx.conf) had no route for the Python Virtual Environment (PVE) REST calls, so they fell through to the catch-all location / and returned 404 from dashboard-service. In the UI this surfaces as a "Could not load Python virtual environments" popup on every Python UDF operator selection.

The root cause is that the frontend requested /pve/... while the backend (PveResource, @Path("/pve"), Jersey mounted under /api/* on the coordinator) serves /api/pve/..., so every gateway had to carry its own /pve to /api/pve rewrite rule, and the single-node config was missing one.

Per review feedback, instead of adding the missing rewrite, this PR removes the mismatch at the source: the frontend now builds PVE URLs with AppSettings.getApiEndpoint() and requests /api/pve/... directly. Every routing layer then becomes a plain routing entry with no path rewriting:

bin/single-node/nginx.conf: location /api/pve/ passes through to the coordinator
frontend/proxy.config.json: /api/pve entry (ordered before /api), pathRewrite removed
bin/k8s/templates/base/gateway/gateway-routes.yaml: /api/pve joins the existing dynamic-backend match list, the URLRewrite filter is removed

The backend is unchanged. Net effect: the 404 is fixed, and the per-gateway rewrite special-casing that allowed the three configs to drift apart is gone.

Any related issues, documentation, discussions?

Related to #5963 (PVE single-node configuration).

How was this PR tested?

virtual-environment.service.spec.ts passes with the new URLs (5 specs).
On the single-node Docker stack: GET /api/pve/pves?cuid=1 returns 200 JSON from the coordinator, and the old /pve path falls through to the dashboard as expected.
helm template renders the updated k8s route with the URLRewrite filter removed.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8, Claude Fable 5)

github-actions · 2026-07-05T02:40:11Z

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

Contributors with relevant context: @bobbai00, @SarahAsad23, @zyratlo
You can notify them by mentioning @bobbai00, @SarahAsad23, @zyratlo in a comment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…xuang7/texera into fix/single-node-nginx-pve-route

Yicong-Huang · 2026-07-06T23:27:28Z

            proxy_set_header Host $host;
        }

+        location /pve/ {


we should change this to /api/pve/ in the src code instead of doing a mapping here.

Agreed. No other comments for me.

Updated, thanks!

Per review: the frontend now calls /api/pve directly via AppSettings.getApiEndpoint(), so the /pve-to-/api/pve rewrite rules in single-node nginx, the dev proxy, and the k8s gateway become plain routing entries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

codecov-commenter · 2026-07-07T21:58:34Z

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.64%. Comparing base (b1c4fd2) to head (e7ee16c).
⚠️ Report is 45 commits behind head on main.

Files with missing lines	Patch %	Lines
...virtual-environment/virtual-environment.service.ts	62.50%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6130      +/-   ##
============================================
+ Coverage     60.26%   60.64%   +0.38%     
  Complexity     3339     3339              
============================================
  Files          1133     1139       +6     
  Lines         43979    44874     +895     
  Branches       4781     4930     +149     
============================================
+ Hits          26503    27214     +711     
- Misses        16021    16173     +152     
- Partials       1455     1487      +32

Flag	Coverage Δ		*Carryforward flag
access-control-service	`70.00% <ø> (ø)`		Carriedforward from b864745
agent-service	`44.59% <ø> (ø)`		Carriedforward from b864745
amber	`65.51% <ø> (ø)`		Carriedforward from b864745
computing-unit-managing-service	`0.00% <ø> (ø)`		Carriedforward from b864745
config-service	`52.30% <ø> (ø)`		Carriedforward from b864745
file-service	`63.97% <ø> (ø)`		Carriedforward from b864745
frontend	`53.26% <62.50%> (+1.28%)`	⬆️
notebook-migration-service	`78.57% <ø> (ø)`		Carriedforward from b864745
pyamber	`91.18% <ø> (ø)`		Carriedforward from b864745
workflow-compiling-service	`55.14% <ø> (ø)`		Carriedforward from b864745

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

v1.2 adaptation of b864745 on main (PR apache#6130): the frontend builds PVE URLs with AppSettings.getApiEndpoint(), so single-node nginx, the dev proxy, and the k8s gateway all become plain routes with no rewriting. Fewer files than on main because this branch predates the StoredPve db endpoints and the gateway chart reorganization. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Copilot

Pull request overview

This PR fixes single-node and gateway routing for Python Virtual Environment (PVE) REST calls by aligning the frontend to call PVE endpoints under the backend’s /api mount (i.e., /api/pve/...) and removing per-gateway /pve -> /api/pve rewrite special-casing across deployment configs.

Changes:

Update the frontend PVE service to build REST URLs using AppSettings.getApiEndpoint() (so requests go to /api/pve/...).
Update local dev proxying and single-node NGINX to route /api/pve directly to the coordinator service.
Update the Kubernetes gateway HTTPRoute to match /api/pve and drop the rewrite filter.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
frontend/src/app/workspace/service/virtual-environment/virtual-environment.service.ts	Switch PVE REST calls to use `AppSettings.getApiEndpoint()` so they resolve under `/api/pve/*`.
frontend/src/app/workspace/service/virtual-environment/virtual-environment.service.spec.ts	Update unit tests to match the new base URL construction.
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts	Update comment to reflect `/api/pve/system` endpoint path.
frontend/proxy.config.json	Add `/api/pve` proxy target to the coordinator and remove the old `/pve` rewrite entry.
bin/single-node/nginx.conf	Add explicit `location /api/pve/` proxying to the workflow-runtime coordinator.
bin/k8s/templates/base/gateway/gateway-routes.yaml	Add `/api/pve` to dynamic backend matches and remove the `/pve` rewrite rule.

Comments suppressed due to low confidence (1)

frontend/src/app/workspace/service/virtual-environment/virtual-environment.service.spec.ts:85

This spec only covers the CRUD /pve/db methods, but this PR also changed the request URLs for getSystemPackages() and fetchPVEs() (and related helpers). Adding unit tests for those methods would prevent regressions in the new /api/pve/* routing (URL + required cuid query param).

  it("deleteUserPve() DELETEs /pve/db/{veid}", () => {
    service.deleteUserPve(9).subscribe();

    const req = httpTestingController.expectOne(`${AppSettings.getApiEndpoint()}/pve/db/9`);
    expect(req.request.method).toBe("DELETE");
    req.flush(null);
  });
});

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…tching Mirrors the same change on the main PR (apache#6130) to keep the two branches identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…tching Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…tching Mirrors the same change on the main PR (apache#6130) to keep the two branches identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: add missing /pve route to single-node nginx

e630331

github-actions Bot assigned xuang7 Jul 5, 2026

github-actions Bot added fix infra labels Jul 5, 2026

Merge branch 'main' into fix/single-node-nginx-pve-route

c4a3037

xuang7 marked this pull request as ready for review July 6, 2026 22:41

xuang7 and others added 2 commits July 6, 2026 15:49

simplify /pve route to prefix-replacing proxy_pass

a913e42

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Merge branch 'fix/single-node-nginx-pve-route' of https://github.com/…

0e13b50

…xuang7/texera into fix/single-node-nginx-pve-route

xuang7 requested review from Yicong-Huang, bobbai00 and kunwp1 July 6, 2026 22:54

xuang7 mentioned this pull request Jul 6, 2026

fix(pve, v1.2): repair Python virtual environment in single-node deployment #6131

Open

Yicong-Huang reviewed Jul 6, 2026

View reviewed changes

github-actions Bot added the frontend Changes related to the frontend GUI label Jul 7, 2026

xuang7 changed the title ~~fix: add missing /pve route to single-node nginx~~ fix: serve PVE requests under /api/pve and drop per-gateway rewrites Jul 7, 2026

xuang7 requested a review from Yicong-Huang July 8, 2026 20:53

Yicong-Huang reviewed Jul 9, 2026

View reviewed changes

Comment thread bin/single-node/nginx.conf Outdated

Yicong-Huang reviewed Jul 9, 2026

View reviewed changes

Comment thread frontend/src/app/workspace/service/virtual-environment/virtual-environment.service.spec.ts

Yicong-Huang reviewed Jul 9, 2026

View reviewed changes

Comment thread frontend/src/app/workspace/service/virtual-environment/virtual-environment.service.ts

xuang7 requested review from Yicong-Huang and aglinxinyuan and removed request for bobbai00 July 9, 2026 17:49

aglinxinyuan requested review from Copilot and removed request for aglinxinyuan July 9, 2026 20:08

Copilot started reviewing on behalf of aglinxinyuan July 9, 2026 20:08 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

xuang7 mentioned this pull request Jul 10, 2026

fix: python virtual environment single node configurations #6029

Closed

group /api/pve/ with the other /api/ locations and document prefix ma…

e7ee16c

…tching Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

xuang7 force-pushed the fix/single-node-nginx-pve-route branch from 95e2bda to e7ee16c Compare July 10, 2026 23:38

xuang7 changed the title ~~fix: serve PVE requests under /api/pve and drop per-gateway rewrites~~ fix(pve): serve PVE requests under /api/pve and drop per-gateway rewrites Jul 10, 2026

Yicong-Huang approved these changes Jul 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(pve): serve PVE requests under /api/pve and drop per-gateway rewrites#6130

fix(pve): serve PVE requests under /api/pve and drop per-gateway rewrites#6130
xuang7 wants to merge 6 commits into
apache:mainfrom
xuang7:fix/single-node-nginx-pve-route

xuang7 commented Jul 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 5, 2026 •

edited

Loading

Uh oh!

Yicong-Huang Jul 6, 2026

Uh oh!

kunwp1 Jul 7, 2026

Uh oh!

xuang7 Jul 7, 2026

Uh oh!

codecov-commenter commented Jul 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

xuang7 commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this PR?

Any related issues, documentation, discussions?

How was this PR tested?

Was this PR authored or co-authored using generative AI tooling?

Uh oh!

github-actions Bot commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automated Reviewer Suggestions

Uh oh!

Yicong-Huang Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

kunwp1 Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

xuang7 Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xuang7 commented Jul 5, 2026 •

edited

Loading

github-actions Bot commented Jul 5, 2026 •

edited

Loading

codecov-commenter commented Jul 7, 2026 •

edited

Loading